Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lecture&course of course7 #1

Merged
merged 19 commits into from
Mar 29, 2024
Merged

Conversation

DawnMagnet
Copy link
Contributor

course7/course_en.md Outdated Show resolved Hide resolved
course7/course_en.md Outdated Show resolved Hide resolved
course7/course_en.md Outdated Show resolved Hide resolved
course7/course_en.md Outdated Show resolved Hide resolved
course7/course_en.md Outdated Show resolved Hide resolved
course7/course_en.md Outdated Show resolved Hide resolved
course7/course_en.md Outdated Show resolved Hide resolved
Copy link
Contributor

@skylee03 skylee03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"enables" is more appropriate than "allows" here.

@DawnMagnet
Copy link
Contributor Author

yes, enable means "to make something possible"

Copy link
Collaborator

@peter-jerry-ye peter-jerry-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is far better than the first version. However modifications still need to be made as the existing explanations are too short (or missing) and the organization is a bit wierd. Since this is a document, you are free to have deeper level then just header level 2.

course7/course_en.md Outdated Show resolved Hide resolved
course7/course_en.md Outdated Show resolved Hide resolved
course7/course_en.md Outdated Show resolved Hide resolved
course7/course_en.md Outdated Show resolved Hide resolved
course7/course_en.md Show resolved Hide resolved
course7/course_en.md Outdated Show resolved Hide resolved
course7/course_en.md Show resolved Hide resolved
@peter-jerry-ye peter-jerry-ye marked this pull request as draft March 8, 2024 09:30
course7/course_en.md Outdated Show resolved Hide resolved
course7/course_en.md Outdated Show resolved Hide resolved
@DawnMagnet DawnMagnet marked this pull request as ready for review March 10, 2024 07:02
Copy link
Contributor Author

@DawnMagnet DawnMagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change all i = i +1 into i += 1

Copy link
Contributor Author

@DawnMagnet DawnMagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor Author

@DawnMagnet DawnMagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update some details

Copy link
Collaborator

@peter-jerry-ye peter-jerry-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be easier if you just translate the script and insert the examples in the right place as #3 (for the following chapters).

course7/course_en.md Show resolved Hide resolved
course7/course_en.md Outdated Show resolved Hide resolved
course7/course_en.md Outdated Show resolved Hide resolved
course7/course_en.md Outdated Show resolved Hide resolved
course7/course_en.md Outdated Show resolved Hide resolved
course7/course_en.md Outdated Show resolved Hide resolved
course7/course_en.md Outdated Show resolved Hide resolved
course7/course_en.md Show resolved Hide resolved
course7/lec7_en.md Outdated Show resolved Hide resolved
course7/course_en.md Show resolved Hide resolved
@peter-jerry-ye peter-jerry-ye requested a review from bobzhang March 15, 2024 08:17
```moonbit
// Loop form
let mut i = 0
while i < 2, i = i + 1 {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mdlint run?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already run. no warnings

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DawnMagnet Are you sure that you used the correct markdown linter (@moonbit/markdown-linter, not mdlint) to check the document?

@peter-jerry-ye
Copy link
Collaborator

Could you please do a rebase?

@DawnMagnet
Copy link
Contributor Author

Could you please do a rebase?

already rebase

@peter-jerry-ye
Copy link
Collaborator

I triggered the CI job and now you can see the changes needed

course7/course_en.md Outdated Show resolved Hide resolved
@skylee03
Copy link
Contributor

skylee03 commented Mar 26, 2024

I think many of the fn inits added in 4e8b34c should be changed to moonbit expr, not only the one just mentioned.

@peter-jerry-ye
Copy link
Collaborator

Using fn init or moonbit expr can be changed later. @skylee03 What do you think about the content? Is is easy to understand and self-explaining?

@skylee03
Copy link
Contributor

Using fn init or moonbit expr can be changed later. @skylee03 What do you think about the content? Is is easy to understand and self-explaining?

I think the content is pretty good, except that MoonBit is sometimes written as “Moonbit”.

@skylee03
Copy link
Contributor

Using fn init or moonbit expr can be changed later. @skylee03 What do you think about the content? Is is easy to understand and self-explaining?

I think the content is pretty good, except that MoonBit is sometimes written as “Moonbit”.

Also, the author should be "MoonBit Open Course Team".

@peter-jerry-ye peter-jerry-ye merged commit 3ee162e into moonbitlang:main Mar 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants